Re: [PATCH] pinctrl: rza1: off by one in rza1_parse_gpiochip()

From: jmondi
Date: Wed Aug 23 2017 - 03:42:31 EST


Hi Linus,
sorry for being late.

With Geert's approval I guess my ack is not that necessary, but...

On Wed, Aug 23, 2017 at 09:35:42AM +0200, Geert Uytterhoeven wrote:
> On Fri, Aug 18, 2017 at 12:32 PM, Dan Carpenter
> <dan.carpenter@xxxxxxxxxx> wrote:
> > The rza1_pctl->ports[] array has RZA1_NPORTS (12) elements. The > here
> > should be >= to prevent an out of bounds access.
> >
> > Fixes: 5a49b644b307 ("pinctrl: Renesas RZ/A1 pin and gpio controller")
> > Signed-off-by: Dan Carpenter <dan.carpenter@xxxxxxxxxx>
>
> Reviewed-by: Geert Uytterhoeven <geert+renesas@xxxxxxxxx>

Acked-by: Jacopo Mondi <jacopo@xxxxxxxxxx>

>
> Gr{oetje,eeting}s,
>
> Geert
>
> --
> Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@xxxxxxxxxxxxxx
>
> In personal conversations with technical people, I call myself a hacker. But
> when I'm talking to journalists I just say "programmer" or something like that.
> -- Linus Torvalds