Re: [PATCH 2/2] staging: android: ion: Change argument to kmalloc (checkpatch)

From: Greg KH
Date: Wed Aug 23 2017 - 01:38:05 EST


On Tue, Aug 22, 2017 at 10:55:37PM -0400, Nick Fox wrote:
> Change argument to kmalloc() to fix style issue, reported by checkpatch
>
> Signed-off-by: Nick Fox <fox.nicholas.j@xxxxxxxxx>
> ---
> drivers/staging/android/ion/ion_cma_heap.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/staging/android/ion/ion_cma_heap.c b/drivers/staging/android/ion/ion_cma_heap.c
> index b06f4cee9c7c..bb2c1449cbcf 100644
> --- a/drivers/staging/android/ion/ion_cma_heap.c
> +++ b/drivers/staging/android/ion/ion_cma_heap.c
> @@ -45,7 +45,7 @@ static int ion_cma_allocate(struct ion_heap *heap, struct ion_buffer *buffer,
> if (!pages)
> return -ENOMEM;
>
> - table = kmalloc(sizeof(struct sg_table), GFP_KERNEL);
> + table = kmalloc(sizeof(*table), GFP_KERNEL);

This doesn't apply to linux-next at all, what tree are you working
against? Always work off of the correct tree please...

thanks,

greg k-h