Re: [PATCH v2 1/6] fsl/fman: enable FMan Keygen

From: David Miller
Date: Wed Aug 23 2017 - 00:46:54 EST


From: Madalin-cristian Bucur <madalin.bucur@xxxxxxx>
Date: Wed, 23 Aug 2017 04:36:56 +0000

> The struct fman is only visible in the fman file, the fman port
> module uses struct fman as an opaque pointer, thus this export.

Don't use that programming model.

Export the datastructure properly to it's users.

This abstraction scheme is so wasteful and costly.