Re: [PATCH] ASoC: Add a sanity check before using dai driver name

[jeffy]

hi Mark,

On 08/23/2017 12:17 AM, Mark Brown wrote:
> On Tue, Aug 22, 2017 at 10:45:12PM +0800, Jeffy Chen wrote:
>
> > -			return dai;
> > +			if (!dlc->dai_name)
> > +				return dai;
> > +			if (!strcmp(dai->name, dlc->dai_name))
> > +				return dai;
>
> You want (dlc->dai_name && !strcmp(dai->name, dlc->dai_name)) for this
> to be equivalent don't you?
i think the original check is allowing NULL dlc dai_name to be a match...
so we basically did:
reject when dlc dai_name is valid, but not match the dai name

and my patch is:
accept when dlc dai_name is invalid
accept when match dai name
accept when match dai driver name(only when it is valid)

so it's a "if (a && b) reject" to "if (!a || !b) accept" case..

> > +			if (dai->driver->name &&
> > +			    !strcmp(dai->driver->name, dlc->dai_name))