Re: [PATCH v7 6/7] ntb: ntb_hw_intel: use io-64-nonatomic instead of in-driver hacks

From: Andy Shevchenko
Date: Tue Aug 22 2017 - 16:14:56 EST


On Tue, Aug 22, 2017 at 8:56 PM, Logan Gunthorpe <logang@xxxxxxxxxxxx> wrote:
>
>
> On 22/08/17 11:41 AM, Andy Shevchenko wrote:
>>>
>>> @@ -59,6 +59,7 @@
>>> #include <linux/random.h>
>>> #include <linux/slab.h>
>>> #include <linux/ntb.h>
>>> +#include <linux/io-64-nonatomic-lo-hi.h>
>>
>>
>> I would rather try to squeeze to most alpabetiacelly ordered part of this
>> block.
>> Otherwise it's a pretty nice clean up!
>>
>
> I don't understand. The includes were not alphabetically in any order
> originally and I'd rather not reorder them in my patch.

In excerpt I see if you put your include before random.h you will get
3 headers in order.
There may be even better sequence, I didn't check.


--
With Best Regards,
Andy Shevchenko