Re: [PATCH v2 01/19] perf, tools: Save max_x, max_y in xyarray

From: Arnaldo Carvalho de Melo
Date: Tue Aug 22 2017 - 10:40:58 EST


Em Tue, Aug 22, 2017 at 10:20:28AM +0200, Jiri Olsa escreveu:
> On Fri, Aug 11, 2017 at 04:26:16PM -0700, Andi Kleen wrote:
> > From: Andi Kleen <ak@xxxxxxxxxxxxxxx>
> > +static inline int xy_max_y(struct xyarray *xy)
> > +{
> > + return xy->max_x;
> > +}
> > +
> > +static inline int xy_max_x(struct xyarray *xy)
> > +{
> > + return xy->max_y;
> > +}
>
> I think you should follow the standard naming
> and use xyarray__max_x and xyarray__max_y

Yeah, will take just a bit longer to process, I'll fix that up...

- Arnaldo