Re: [PATCH 15/15] usb: make device_type const

From: Heikki Krogerus
Date: Tue Aug 22 2017 - 09:02:19 EST


On Sat, Aug 19, 2017 at 01:52:26PM +0530, Bhumika Goyal wrote:
> Make this const as it is only stored in the type field of a device
> structure, which is const.
> Done using Coccinelle.
>
> Signed-off-by: Bhumika Goyal <bhumirks@xxxxxxxxx>

Acked-by: Heikki Krogerus <heikki.krogerus@xxxxxxxxxxxxxxx>

> ---
> drivers/usb/common/ulpi.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/usb/common/ulpi.c b/drivers/usb/common/ulpi.c
> index 930e8f3..4aa5195 100644
> --- a/drivers/usb/common/ulpi.c
> +++ b/drivers/usb/common/ulpi.c
> @@ -135,7 +135,7 @@ static void ulpi_dev_release(struct device *dev)
> kfree(to_ulpi_dev(dev));
> }
>
> -static struct device_type ulpi_dev_type = {
> +static const struct device_type ulpi_dev_type = {
> .name = "ulpi_device",
> .groups = ulpi_dev_attr_groups,
> .release = ulpi_dev_release,

Thanks,

--
heikki