Re: [PATCH] pinctrl: amd: fix error return code in amd_gpio_probe()

From: Linus Walleij
Date: Tue Aug 22 2017 - 08:25:08 EST


On Wed, Aug 9, 2017 at 6:09 PM, Gustavo A. R. Silva
<gustavo@xxxxxxxxxxxxxx> wrote:

> platform_get_irq() returns an error code, but the pinctrl-amd driver
> ignores it and always returns -EINVAL. This is not correct and,
> prevents -EPROBE_DEFER from being propagated properly.
>
> Print and propagate the return value of platform_get_irq on failure.
>
> This issue was detected with the help of Coccinelle.
>
> Signed-off-by: Gustavo A. R. Silva <gustavo@xxxxxxxxxxxxxx>

Patch applied.

Yours,
Linus Walleij