Re: [PATCH 1/2] ext4: fix warning about stack corruption

From: Arnd Bergmann
Date: Tue Aug 22 2017 - 07:57:20 EST


On Tue, Aug 22, 2017 at 1:08 PM, Anton Blanchard <anton@xxxxxxxxxx> wrote:
> Hi Arnd,
>>
>> Note that while clang won't allow certain kinds of variable-length
>> arrays in structures, this particular instance is fine, as the array
>> is at the end of the structure, and the size is strictly bounded.
>
> Unfortunately it doesn't appear to work, at least with ppc64le clang:
>
> fs/ext4/mballoc.c:2303:17: error: fields must have a constant size: 'variable length array in structure' extension will never be supported
> ext4_grpblk_t counters[blocksize_bits + 2];

My fix for this is in the ext4/dev branch in linux-next, I hope it still
makes it into v4.13.

Arnd