Re: [PATCH v2 1/3] dt-bindings: add eeprom "size" property

From: Sakari Ailus
Date: Tue Aug 22 2017 - 05:11:14 EST


Hi Divagar,

On Tue, Aug 15, 2017 at 12:11:57AM +0530, Divagar Mohandass wrote:
> This adds eeprom "size" as optional property for i2c eeproms.
>
> "size" should be mentioned in byte and it should refer
> to the eeprom size. This will be read by the driver and
> used to calculating the number of bytes in read/write calls.

Instead of the three lines above, how about:

The "size" property allows explicitly specifying the size of the EEPROM
chip in bytes.

>
> Signed-off-by: Divagar Mohandass <divagar.mohandass@xxxxxxxxx>
> ---
> Documentation/devicetree/bindings/eeprom/eeprom.txt | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/Documentation/devicetree/bindings/eeprom/eeprom.txt b/Documentation/devicetree/bindings/eeprom/eeprom.txt
> index 5696eb5..1436569 100644
> --- a/Documentation/devicetree/bindings/eeprom/eeprom.txt
> +++ b/Documentation/devicetree/bindings/eeprom/eeprom.txt
> @@ -32,6 +32,8 @@ Optional properties:
>
> - read-only: this parameterless property disables writes to the eeprom
>
> + - size: total eeprom size in bytes
> +
> Example:
>
> eeprom@52 {
> --
> 1.9.1
>

--
Regards,

Sakari Ailus
e-mail: sakari.ailus@xxxxxx