Re: [PATCH 4/6] dpaa_eth: add NETIF_F_RXHASH

From: David Miller
Date: Mon Aug 21 2017 - 13:57:15 EST


From: Madalin Bucur <madalin.bucur@xxxxxxx>
Date: Fri, 18 Aug 2017 11:56:26 +0300

> + if (net_dev->features & NETIF_F_RXHASH && priv->keygen_in_use &&
> + !fman_port_get_hash_result_offset(priv->mac_dev->port[RX],
> + &hash_offset))
> + skb_set_hash(skb, be32_to_cpu(*(u32 *)(vaddr + hash_offset)),
> + // if L4 exists, it was used in the hash generation
> + be32_to_cpu(fd->status) & FM_FD_STAT_L4CV ?
> + PKT_HASH_TYPE_L4 : PKT_HASH_TYPE_L3);

We do not use "//" c++ style comments in the kernel.

And putting a comment right in the middle of a set of arguments being
passed to a function makes the code harder to read, so please do not
do this.