Re: [PATCH v2] soc: ti: knav: Add a NULL pointer check for kdev in knav_pool_create

From: Arnd Bergmann
Date: Mon Aug 21 2017 - 03:21:14 EST


On Mon, Aug 21, 2017 at 7:44 AM, santosh.shilimkar@xxxxxxxxxx
<santosh.shilimkar@xxxxxxxxxx> wrote:
> Hi Arnd,
>
> On 7/30/17 9:31 PM, Keerthy wrote:
>>
>> knav_pool_create is an exported function. In the event of a call
>> before knav_queue_probe, we encounter a NULL pointer dereference
>> in the following line. Hence return -EPROBE_DEFER to the caller till
>> the kdev pointer is non-NULL.
>>
>> Signed-off-by: Keerthy <j-keerthy@xxxxxx>
>> ---
>>
>> Changes in v2:
>>
>> * Fixed returning an int to returning pointer.
>
> FWIW, Acked-by: Santosh Shilimkar <santosh.shilimkar@xxxxxxxxxx>
>
> Can you please also apply this fix in your fixes branch ?

Applied now, thanks!

Arnd