Re: Possible null pointer dereference in rcar-dmac.ko

From: Kuninori Morimoto
Date: Mon Aug 21 2017 - 02:15:28 EST



Hi Laurent

> I don't think this fully fixes the problem, as the rcar_dmac_isr_error() IRQ
> handler is still registered before all this. Furthermore, at least some of the
> initialization at the end of rcar_dmac_chan_probe() has to be moved before the
> rcar_dmac_isr_channel() IRQ handler registration.
>
> Let's not commit a quick hack but fix the problem correctly, we should ensure
> that all the initialization needed by IRQ handlers is performed before they
> get registered.

Yeah, indeed.
We need v2 patch

Best regards
---
Kuninori Morimoto