Re: [PATCH 2/4] gpu: host1x: Enable gather filter

From: Dmitry Osipenko
Date: Sat Aug 19 2017 - 08:06:09 EST


On 19.08.2017 13:46, Mikko Perttunen wrote:
> On 08/19/2017 01:42 PM, Dmitry Osipenko wrote:
>> On 18.08.2017 19:15, Mikko Perttunen wrote:
>>> The gather filter is a feature present on Tegra124 and newer where the
>>> hardware prevents GATHERed command buffers from executing commands
>>> normally reserved for the CDMA pushbuffer which is maintained by the
>>> kernel driver.
>>>
>>> This commit enables the gather filter on all supporting hardware.
>>>
>>> Signed-off-by: Mikko Perttunen <mperttunen@xxxxxxxxxx>
>>> ---
>>
>> TRM says that "Invalid Gbuffer cmd" interrupt would be raised when filtering
>> happens. Is that interrupt disabled by default or it would cause 'unhandled
>> interrupt'?
>>
>
> It's disabled by default. Jobs that are stopped by the filter are then handled
> by the usual timeout mechanism.
>

Alright, then it looks good to me.

Reviewed-by: Dmitry Osipenko <digetx@xxxxxxxxx>

--
Dmitry