Re: [PATCH 4.12 47/65] usb:xhci:Add quirk for Certain failing HP keyboard on reset after resume

[Ben Hutchings]

On Mon, 2017-08-14 at 18:19 -0700, Greg Kroah-Hartman wrote:
> 4.12-stable review patch.ÂÂIf anyone has any objections, please let me know.
> 
> ------------------
> 
> From: Sandeep Singh <sandeep.singh@xxxxxxx>
> 
> commit e788787ef4f9c24aafefc480a8da5f92b914e5e6 upstream.
[...]
> --- a/drivers/usb/host/pci-quirks.c
> +++ b/drivers/usb/host/pci-quirks.c
> @@ -98,6 +98,7 @@ enum amd_chipset_gen {
> Â	AMD_CHIPSET_HUDSON2,
> Â	AMD_CHIPSET_BOLTON,
> Â	AMD_CHIPSET_YANGTZE,
> +	AMD_CHIPSET_TAISHAN,
> Â	AMD_CHIPSET_UNKNOWN,
> Â};
> Â
> @@ -141,6 +142,11 @@ static int amd_chipset_sb_type_init(stru
> Â			pinfo->sb_type.gen = AMD_CHIPSET_SB700;
> Â		else if (rev >= 0x40 && rev <= 0x4f)
> Â			pinfo->sb_type.gen = AMD_CHIPSET_SB800;
> +	}
> +	pinfo->smbus_dev = pci_get_device(PCI_VENDOR_ID_AMD,
> +					ÂÂ0x145c, NULL);
> +	if (pinfo->smbus_dev) {
> +		pinfo->sb_type.gen = AMD_CHIPSET_TAISHAN;
> Â	} else {
> Â		pinfo->smbus_dev = pci_get_device(PCI_VENDOR_ID_AMD,
> Â				PCI_DEVICE_ID_AMD_HUDSON2_SMBUS, NULL);
[...]

This causes pinfo->smbus_dev to be wrongly set to NULL on systems with
the ATI chipset that this function checks for first.

Ben.

-- 
Ben Hutchings
Reality is just a crutch for people who can't handle science fiction.

Attachment: signature.asc
Description: This is a digitally signed message part