Re: [PATCH] video: fbdev: constify copied structures

From: Bartlomiej Zolnierkiewicz
Date: Fri Aug 18 2017 - 13:41:28 EST



Hi,

On Wednesday, August 02, 2017 11:04:39 AM Julia Lawall wrote:
> Make const some structures that are only copied into other structures.
>
> Signed-off-by: Julia Lawall <Julia.Lawall@xxxxxxx>

fb_fix_screeninfo and fb_var_screeninfo structures were already
const-ified by commit 40445365a43f ("video: xilinxfb: constify
fb_fix_screeninfo and fb_var_screeninfo structures") in my -next
tree (git://github.com/bzolnier/linux.git fbdev-for-next) so
I just applied xilinx_fb_default_pdata part (patch included below
for reference).

Best regards,
--
Bartlomiej Zolnierkiewicz
Samsung R&D Institute Poland
Samsung Electronics


From: Julia Lawall <Julia.Lawall@xxxxxxx>
Subject: [PATCH] video: fbdev: xilinxfb: constify copied structure

Make const xilinx_fb_default_pdata structure that is only copied into
other structure.

Signed-off-by: Julia Lawall <Julia.Lawall@xxxxxxx>
Cc: Michal Simek <michal.simek@xxxxxxxxxx>
Cc: Soren Brinkmann <soren.brinkmann@xxxxxxxxxx>,
[b.zolnierkie: split from a bigger patch]
Signed-off-by: Bartlomiej Zolnierkiewicz <b.zolnierkie@xxxxxxxxxxx>
---
drivers/video/fbdev/xilinxfb.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

Index: b/drivers/video/fbdev/xilinxfb.c
===================================================================
--- a/drivers/video/fbdev/xilinxfb.c 2017-08-18 19:34:11.383004874 +0200
+++ b/drivers/video/fbdev/xilinxfb.c 2017-08-18 19:34:35.383005478 +0200
@@ -100,7 +100,7 @@ struct xilinxfb_platform_data {
/*
* Default xilinxfb configuration
*/
-static struct xilinxfb_platform_data xilinx_fb_default_pdata = {
+static const struct xilinxfb_platform_data xilinx_fb_default_pdata = {
.xres = 640,
.yres = 480,
.xvirt = 1024,