RE: [PATCH] vsock: only load vmci transport on VMware hypervisor by default

From: Dexuan Cui
Date: Thu Aug 17 2017 - 14:28:01 EST


> From: David Miller [mailto:davem@xxxxxxxxxxxxx]
> Sent: Thursday, August 17, 2017 10:04
> I would avoid module parameters at all costs.
>
> It is the worst possible interface for users of your software.
>
> You really need to fundamentally solve the problems related to making
> sure the proper modules for the VM actually present on the system get
> loaded when necessary rather than adding hacks like this.
>
> Unlike a proper solution, these hacks are ugly but have to stay around
> forever once you put them in place.

Sorry for reminding me again, David! :-)

I'll try to figure out the correct solution.

Thanks,
-- Dexuan