Re: [PATCH v4 3/4] dt-bindings: can: m_can: Document new can transceiver binding

From: Rob Herring
Date: Thu Aug 17 2017 - 11:12:42 EST


On Wed, Aug 09, 2017 at 07:59:15PM -0500, Franklin S Cooper Jr wrote:
> Add information regarding can-transceiver binding. This is especially
> important for MCAN since the IP allows CAN FD mode to run significantly
> faster than what most transceivers are capable of.
>
> Signed-off-by: Franklin S Cooper Jr <fcooper@xxxxxx>
> ---
> Drop unit address.
> Switch from using fixed-transceiver to can-transceiver
> Indicate that can-transceiver is an optional subnode not a property.
>
> Documentation/devicetree/bindings/net/can/m_can.txt | 9 +++++++++
> 1 file changed, 9 insertions(+)
>
> diff --git a/Documentation/devicetree/bindings/net/can/m_can.txt b/Documentation/devicetree/bindings/net/can/m_can.txt
> index 9e33177..ee90aac 100644
> --- a/Documentation/devicetree/bindings/net/can/m_can.txt
> +++ b/Documentation/devicetree/bindings/net/can/m_can.txt
> @@ -43,6 +43,11 @@ Required properties:
> Please refer to 2.4.1 Message RAM Configuration in
> Bosch M_CAN user manual for details.
>
> +Optional Subnode:
> +- can-transceiver : Can-transceiver subnode describing maximum speed
> + that can be used for CAN/CAN-FD modes. See
> + Documentation/devicetree/bindings/net/can/can-transceiver.txt
> + for details.
> Example:
> SoC dtsi:
> m_can1: can@020e8000 {
> @@ -64,4 +69,8 @@ Board dts:
> pinctrl-names = "default";
> pinctrl-0 = <&pinctrl_m_can1>;
> status = "enabled";
> +
> + can-transceiver@ {

ditto

Acked-by: Rob Herring <robh@xxxxxxxxxx>

> + max-bitrate = <5000000>;
> + };
> };
> --
> 2.9.4.dirty
>