Re: [PATCH] btrfs: remove redundant check on ret being non-zero

From: David Sterba
Date: Thu Aug 17 2017 - 07:53:49 EST


On Tue, Aug 15, 2017 at 08:51:02AM +0100, Colin King wrote:
> From: Colin Ian King <colin.king@xxxxxxxxxxxxx>
>
> The error return variable ret is initialized to zero and then is
> checked to see if it is non-zero in the if-block that follows it.
> It is therefore impossible for ret to be non-zero after the if-block
> hence the check is redundant and can be removed.
>
> Detected by CoverityScan, CID#1021040 ("Logically dead code")
>
> Signed-off-by: Colin Ian King <colin.king@xxxxxxxxxxxxx>

Reviewed-by: David Sterba <dsterba@xxxxxxxx>