Re: [PATCH v3 3/5] reset: stm32: use the reset-simple driver

From: Andreas FÃrber
Date: Wed Aug 16 2017 - 08:55:58 EST


Hi Eugeniy,

Am 16.08.2017 um 14:52 schrieb Eugeniy Paltsev:
> On Wed, 2017-08-16 at 11:46 +0200, Philipp Zabel wrote:
>> The reset-simple driver can be used without changes.
>>
>> Signed-off-by: Philipp Zabel <p.zabel@xxxxxxxxxxxxxx>
>> [snip]
>>
>> --- a/drivers/reset/reset-simple.c
>> +++ b/drivers/reset/reset-simple.c
>> @@ -120,6 +120,7 @@ static const struct reset_simple_devdata
>> reset_simple_active_low = {
>>
>> static const struct of_device_id reset_simple_dt_ids[] = {
>> { .compatible = "altr,rst-mgr", .data =
>> &reset_simple_socfpga },
>> + { .compatible = "st,stm32-rcc", },
>> { .compatible = "allwinner,sun6i-a31-clock-reset",
>> .data = &reset_simple_active_low },
>> { /* sentinel */ },
>
> What about adding generic compatible strings for future use?

Please see 1/5 for the same discussion, raised by Andre and me.

Thanks,
Andreas

--
SUSE Linux GmbH, Maxfeldstr. 5, 90409 NÃrnberg, Germany
GF: Felix ImendÃrffer, Jane Smithard, Graham Norton
HRB 21284 (AG NÃrnberg)