Re: [PATCH v2 2/4] mmc: sdhci: remove #indef CONFIG_PM around function declarations

[Adrian Hunter]

On 03/08/17 04:44, Masahiro Yamada wrote:
> We need not surround declarations with #ifdef.  Besides, drivers may
> want to call these from PM callbacks marked with __maybe_unused.

No, we use #ifdef not __maybe_unused, and removing the #ifdef is misleading.

> 
> Signed-off-by: Masahiro Yamada <yamada.masahiro@xxxxxxxxxxxxx>
> ---
> 
> Changes in v2:
>   - Newly added
> 
>  drivers/mmc/host/sdhci.h | 4 ----
>  1 file changed, 4 deletions(-)
> 
> diff --git a/drivers/mmc/host/sdhci.h b/drivers/mmc/host/sdhci.h
> index 0469fa191493..773b38127da2 100644
> --- a/drivers/mmc/host/sdhci.h
> +++ b/drivers/mmc/host/sdhci.h
> @@ -709,15 +709,11 @@ void sdhci_set_ios(struct mmc_host *mmc, struct mmc_ios *ios);
>  int sdhci_start_signal_voltage_switch(struct mmc_host *mmc,
>  				      struct mmc_ios *ios);
>  void sdhci_enable_sdio_irq(struct mmc_host *mmc, int enable);
> -
> -#ifdef CONFIG_PM
>  int sdhci_suspend_host(struct sdhci_host *host);
>  int sdhci_resume_host(struct sdhci_host *host);
>  void sdhci_enable_irq_wakeups(struct sdhci_host *host);
>  int sdhci_runtime_suspend_host(struct sdhci_host *host);
>  int sdhci_runtime_resume_host(struct sdhci_host *host);
> -#endif
> -
>  void sdhci_cqe_enable(struct mmc_host *mmc);
>  void sdhci_cqe_disable(struct mmc_host *mmc, bool recovery);
>  bool sdhci_cqe_irq(struct sdhci_host *host, u32 intmask, int *cmd_error,
>