Re: [PATCH] platform/x86: intel_scu_ipc: make intel_scu_ipc_pdata_t const

From: Andy Shevchenko
Date: Sun Aug 13 2017 - 08:30:55 EST


On Fri, Aug 11, 2017 at 4:19 PM, Bhumika Goyal <bhumirks@xxxxxxxxx> wrote:
> Make these const as they are only used during a copy operation.
>
> Done using Coccinelle.
>

Both patches pushed to testing, thanks!

> Signed-off-by: Bhumika Goyal <bhumirks@xxxxxxxxx>
> ---
> drivers/platform/x86/intel_scu_ipc.c | 6 +++---
> 1 file changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/platform/x86/intel_scu_ipc.c b/drivers/platform/x86/intel_scu_ipc.c
> index f7cf981..2c85f75 100644
> --- a/drivers/platform/x86/intel_scu_ipc.c
> +++ b/drivers/platform/x86/intel_scu_ipc.c
> @@ -72,20 +72,20 @@ struct intel_scu_ipc_pdata_t {
> u8 irq_mode;
> };
>
> -static struct intel_scu_ipc_pdata_t intel_scu_ipc_lincroft_pdata = {
> +static const struct intel_scu_ipc_pdata_t intel_scu_ipc_lincroft_pdata = {
> .i2c_base = 0xff12b000,
> .i2c_len = 0x10,
> .irq_mode = 0,
> };
>
> /* Penwell and Cloverview */
> -static struct intel_scu_ipc_pdata_t intel_scu_ipc_penwell_pdata = {
> +static const struct intel_scu_ipc_pdata_t intel_scu_ipc_penwell_pdata = {
> .i2c_base = 0xff12b000,
> .i2c_len = 0x10,
> .irq_mode = 1,
> };
>
> -static struct intel_scu_ipc_pdata_t intel_scu_ipc_tangier_pdata = {
> +static const struct intel_scu_ipc_pdata_t intel_scu_ipc_tangier_pdata = {
> .i2c_base = 0xff00d000,
> .i2c_len = 0x10,
> .irq_mode = 0,
> --
> 1.9.1
>



--
With Best Regards,
Andy Shevchenko