Re: [PATCH v2 2/9] dt-bindings: regulator: Add document for MediaTek MT6380 regulator

[Sean Wang]

On Mon, 2017-07-24 at 13:22 -0500, Rob Herring wrote:
> On Tue, Jul 18, 2017 at 05:49:22PM +0800, sean.wang@xxxxxxxxxxxx wrote:
> > From: Sean Wang <sean.wang@xxxxxxxxxxxx>
> > 
> > add dt-binding document for MediaTek MT6380 PMIC
> > 
> > Signed-off-by: Chenglin Xu <chenglin.xu@xxxxxxxxxxxx>
> > Signed-off-by: Sean Wang <sean.wang@xxxxxxxxxxxx>
> > ---
> >  .../bindings/regulator/mt6380-regulator.txt        | 90 ++++++++++++++++++++++
> >  1 file changed, 90 insertions(+)
> >  create mode 100644 Documentation/devicetree/bindings/regulator/mt6380-regulator.txt
> > 
> > diff --git a/Documentation/devicetree/bindings/regulator/mt6380-regulator.txt b/Documentation/devicetree/bindings/regulator/mt6380-regulator.txt
> > new file mode 100644
> > index 0000000..2a559f0
> > --- /dev/null
> > +++ b/Documentation/devicetree/bindings/regulator/mt6380-regulator.txt
> > @@ -0,0 +1,90 @@
> > +MediaTek MT6380 Regulator Driver
> 
> Bindings don't describe drivers.
> 
will fix it.

> > +
> > +All voltage regulators are defined as subnodes of the regulators node. A list
> 
> What's the regulators node a child of?
> 

this two line i felt are a little confusion, i will change them into "
all voltage regulators provided by the MT6380 PMIC are described as the
subnodes of the mt6380regulators node "

> > +of regulators provided by this controller are defined as subnodes of the
> > +PMIC's node. Each regulator is named according to its regulator type,
> > +buck-<name> and ldo-<name>. The definition for each of these nodes is defined
> > +using the standard binding for regulators at
> > +Documentation/devicetree/bindings/regulator/regulator.txt.
> > +
> > +The valid names for regulators are:
> > +BUCK:
> > +  buck-core1, buck-vcore, buck-vrf
> > +LDO:
> > +  ldo-vm ,ldo-va , ldo-vphy, ldo-vddr, ldo-vt