[PATCH 2/5] ASoC: dapm: Improve a size determination in two functions

From: SF Markus Elfring
Date: Thu Aug 10 2017 - 09:03:02 EST


From: Markus Elfring <elfring@xxxxxxxxxxxxxxxxxxxxx>
Date: Thu, 10 Aug 2017 14:15:47 +0200

Replace the specification of data structures by pointer dereferences
as the parameter for the operator "sizeof" to make the corresponding size
determination a bit safer according to the Linux coding style convention.

Signed-off-by: Markus Elfring <elfring@xxxxxxxxxxxxxxxxxxxxx>
---
sound/soc/soc-dapm.c | 9 ++++-----
1 file changed, 4 insertions(+), 5 deletions(-)

diff --git a/sound/soc/soc-dapm.c b/sound/soc/soc-dapm.c
index 3adb914bc009..e673961210e6 100644
--- a/sound/soc/soc-dapm.c
+++ b/sound/soc/soc-dapm.c
@@ -2651,7 +2651,7 @@ static int snd_soc_dapm_add_path(struct snd_soc_dapm_context *dapm,
if (ret)
return ret;

- path = kzalloc(sizeof(struct snd_soc_dapm_path), GFP_KERNEL);
+ path = kzalloc(sizeof(*path), GFP_KERNEL);
if (!path)
return -ENOMEM;

@@ -3859,10 +3859,9 @@ int snd_soc_dapm_new_pcm(struct snd_soc_card *card,
}
kcontrol_dai_link[0].private_value = private_value;
/* duplicate kcontrol_dai_link on heap so that memory persists */
- template.kcontrol_news =
- devm_kmemdup(card->dev, &kcontrol_dai_link[0],
- sizeof(struct snd_kcontrol_new),
- GFP_KERNEL);
+ template.kcontrol_news = devm_kmemdup(card->dev, &kcontrol_dai_link[0],
+ sizeof(*template.kcontrol_news),
+ GFP_KERNEL);
if (!template.kcontrol_news) {
ret = -ENOMEM;
goto outfree_private_value;
--
2.14.0