Re: [PATCH 0/4] net-next: dsa: fix flow dissection

From: David Miller
Date: Thu Aug 10 2017 - 01:52:52 EST


From: John Crispin <john@xxxxxxxxxxx>
Date: Wed, 9 Aug 2017 14:41:15 +0200

> RPS and probably other kernel features are currently broken on some if not
> all DSA devices. The root cause of this is that skb_hash will call the
> flow_dissector. At this point the skb still contains the magic switch
> header and the skb->protocol field is not set up to the correct 802.3
> value yet. By the time the tag specific code is called, removing the header
> and properly setting the protocol an invalid hash is already set. In the
> case of the mt7530 this will result in all flows always having the same
> hash.
>
> Changes since RFC:
> * use a callback instead of static values
> * add cover letter

Series applied, thanks.