Re: [tpmdd-devel] [PATCH] tpm: improve tpm_tis send() performance by ignoring burstcount

From: Ken Goldman
Date: Wed Aug 09 2017 - 16:22:45 EST


On 8/8/2017 3:11 PM, Jarkko Sakkinen wrote:
On Mon, Aug 07, 2017 at 01:52:34PM +0200, Peter Huewe wrote:
Imho: NACK from my side.
After these viewpoints definitive NACK from my side too...


I responded to the thread comments separately. However, assuming NACK is the final response, I have a question.

The problem is the 5 msec sleep between polls of burst count. In the case of one TPM with an 8 byte FIFO, a 32 byte transfer incurs 4 of these sleeps.

Would another solution be to reduce the burst count poll and sleep to, e.g., 100 usec or even 10 usec? This would probably help greatly, but still not incur the wait states that triggered the NACK.

My worry is that the scheduler would not be able to context switch that fast, and so we wouldn't actually see usec speed polling.

Can a kernel expert offer an opinion?