Re: [PATCH] thermal/drivers/hisi: Remove confusing error message

[Zhang Rui]

On Fri, 2017-07-07 at 17:03 +0200, Daniel Lezcano wrote:
> The sensor id is unknown at init time and we use all id in the
> authorized
> MAX_SENSORS interval to register the sensor. On this SoC there is one
> thermal-zone with one sensor on it. No need to spit on the console
> everytime we
> failed to register thermal sensors, information which is deliberaly
> known as it
> is part of the discovery process.
> 
> Âhisi_thermal f7030700.tsensor: failed to register sensor id 0: -19
> Âhisi_thermal f7030700.tsensor: failed to register thermal sensor:
> -19
> Âhisi_thermal f7030700.tsensor: failed to register sensor id 1: -19
> Âhisi_thermal f7030700.tsensor: failed to register thermal sensor:
> -19
> Âhisi_thermal f7030700.tsensor: failed to register sensor id 3: -19
> Âhisi_thermal f7030700.tsensor: failed to register thermal sensor:
> -19
> 
> Remove the error messages.
> 
> Signed-off-by: Daniel Lezcano <daniel.lezcano@xxxxxxxxxx>
> ---
> Âdrivers/thermal/hisi_thermal.c | 12 ++++++------
> Â1 file changed, 6 insertions(+), 6 deletions(-)
> 
> diff --git a/drivers/thermal/hisi_thermal.c
> b/drivers/thermal/hisi_thermal.c
> index f642966..2cc98c6 100644
> --- a/drivers/thermal/hisi_thermal.c
> +++ b/drivers/thermal/hisi_thermal.c
> @@ -187,6 +187,9 @@ static int hisi_thermal_get_temp(void *_sensor,
> int *temp)
> Â
> Â	dev_dbg(&data->pdev->dev, "id=%d, irq=%d, temp=%d,
> thres=%d\n",
> Â		sensor->id, data->irq_enabled, *temp, sensor-
> >thres_temp);
> +
> +	printk("id=%d, irq=%d, temp=%d, thres=%d\n",
> +		sensor->id, data->irq_enabled, *temp, sensor-
> >thres_temp);

what's this printk for?

> Â	/*
> Â	Â* Bind irq to sensor for two cases:
> Â	Â*ÂÂÂReenable alarm IRQ if temperature below threshold;
> @@ -260,8 +263,6 @@ static int hisi_thermal_register_sensor(struct
> platform_device *pdev,
> Â	if (IS_ERR(sensor->tzd)) {
> Â		ret = PTR_ERR(sensor->tzd);
> Â		sensor->tzd = NULL;
> -		dev_err(&pdev->dev, "failed to register sensor id
> %d: %d\n",
> -			sensor->id, ret);
> Â		return ret;
> Â	}
> Â
> @@ -352,10 +353,9 @@ static int hisi_thermal_probe(struct
> platform_device *pdev)
> Â		ret = hisi_thermal_register_sensor(pdev, data,
> Â						ÂÂÂ&data-
> >sensors[i], i);
> Â		if (ret)
> -			dev_err(&pdev->dev,
> -				"failed to register thermal sensor:
> %d\n", ret);
> -		else
> -			hisi_thermal_toggle_sensor(&data-
> >sensors[i], true);
> +			continue;
> +
> +		hisi_thermal_toggle_sensor(&data->sensors[i], true);
> Â	}
> Â
> Â	return 0;

With these removed, is there any other information in dmesg that
suggests this failure?

thanks,
rui