Re: [PATCH v1 4/6] ASoC: codecs: msm8916-wcd-analog: set default micbias voltage to 1.8

From: Srinivas Kandagatla
Date: Mon Jul 31 2017 - 06:27:30 EST




On 31/07/17 11:07, Mark Brown wrote:
On Fri, Jul 28, 2017 at 03:45:08PM +0100, Srinivas Kandagatla wrote:
On 28/07/17 15:01, Mark Brown wrote:
On Fri, Jul 28, 2017 at 02:54:59PM +0100, Srinivas Kandagatla wrote:

This was set to 2.7v previously for special headsets which have high
impedance.

So obviously this will break existing users. That's not OK.

This would not break any exiting users, as this part is applicable for only
headset detect usecase. I will try to address this in ("PATCH 5/6 ASoC:
codecs: msm8916-wcd-analog: add MBHC support") patch.

The default voltage for most common usecase should be set to 1.8v anyway.

Just leave it at the hardware default like we do for everything else in
ASoC.
Yep, makes sense, the hw default is at 1.8v.

thanks,
srini