Re: [RESEND PATCH 2/6] ipc: mqueue: Replace timespec with timespec64

From: Deepa Dinamani
Date: Fri Jul 28 2017 - 16:44:32 EST


On Fri, Jul 28, 2017 at 1:15 PM, Paul Moore <paul@xxxxxxxxxxxxxx> wrote:
> On Fri, Jul 28, 2017 at 2:52 PM, Deepa Dinamani <deepa.kernel@xxxxxxxxx> wrote:
>> struct timespec is not y2038 safe. Replace
>> all uses of timespec by y2038 safe struct timespec64.
>>
>> Even though timespec is used here to represent timeouts,
>> replace these with timespec64 so that it facilitates
>> in verification by creating a y2038 safe kernel image
>> that is free of timespec.
>>
>> The syscall interfaces themselves are not changed as part
>> of the patch. They will be part of a different series.
>>
>> Signed-off-by: Deepa Dinamani <deepa.kernel@xxxxxxxxx>
>> Cc: Paul Moore <paul@xxxxxxxxxxxxxx>
>> Cc: Richard Guy Briggs <rgb@xxxxxxxxxx>
>> ---
>> include/linux/audit.h | 6 +++---
>> ipc/mqueue.c | 28 ++++++++++++++--------------
>> kernel/audit.h | 2 +-
>> kernel/auditsc.c | 12 ++++++------
>> 4 files changed, 24 insertions(+), 24 deletions(-)
>
> Something is wrong here ... I already merged your audit y2038 fixes,
> you can see them in Linus' tree right now.

This is the audit record for ipc mqueue side of things.
The other patch does not touch this:

-Deepa

On Fri, Jul 28, 2017 at 1:15 PM, Paul Moore <paul@xxxxxxxxxxxxxx> wrote:
> On Fri, Jul 28, 2017 at 2:52 PM, Deepa Dinamani <deepa.kernel@xxxxxxxxx> wrote:
>> struct timespec is not y2038 safe. Replace
>> all uses of timespec by y2038 safe struct timespec64.
>>
>> Even though timespec is used here to represent timeouts,
>> replace these with timespec64 so that it facilitates
>> in verification by creating a y2038 safe kernel image
>> that is free of timespec.
>>
>> The syscall interfaces themselves are not changed as part
>> of the patch. They will be part of a different series.
>>
>> Signed-off-by: Deepa Dinamani <deepa.kernel@xxxxxxxxx>
>> Cc: Paul Moore <paul@xxxxxxxxxxxxxx>
>> Cc: Richard Guy Briggs <rgb@xxxxxxxxxx>
>> ---
>> include/linux/audit.h | 6 +++---
>> ipc/mqueue.c | 28 ++++++++++++++--------------
>> kernel/audit.h | 2 +-
>> kernel/auditsc.c | 12 ++++++------
>> 4 files changed, 24 insertions(+), 24 deletions(-)
>
> Something is wrong here ... I already merged your audit y2038 fixes,
> you can see them in Linus' tree right now.
>
> --
> paul moore
> www.paul-moore.com