Re: [PATCH] staging: pi433: use div_u64 for 64-bit division

From: Dan Carpenter
Date: Fri Jul 28 2017 - 10:26:57 EST


On Fri, Jul 28, 2017 at 04:21:05PM +0200, Marcus Wolf wrote:
> Hi Arnd,
>
> we already have a patch for this:
> [PATCH 1/1] staging: pi433: fix problem with division in rf69_set_deviation
> from 20.07.2017


https://patchwork.kernel.org/patch/9855261/

>
> Maybe I did something wrong, but my first solution was exactly like your
> proposal. As far as I remeber, I wasn't able to compile it that way. Therefore I
> made a little bit more complicated fix. If I did something wrong and yours is
> fine, we should go for yours, because it is a shorter solution.
>

Your patch doesn't apply for one thing.... :( Read
Documentation/process/email-clients.rst It probably would have been Ok
otherwise.

I'm pretty sure that Arnd's patch is going to be fine.

regards,
dan carpenter