Re: [RFC PATCH 6/8] EDAC, mce_amd: Convert to seq_buf

From: Borislav Petkov
Date: Fri Jul 28 2017 - 03:10:22 EST


On Thu, Jul 27, 2017 at 09:47:08PM -0400, Steven Rostedt wrote:
> What happens if two CPUs have mce's at the same time? Wouldn't one
> corrupt the other buffer. 128 isn't too big to put on the stack is it?

Yeah, putting it on the stack is probably safer, just in case.

What is even better, though, is if I extended
arch/x86/kernel/cpu/mcheck/mce-genpool.c to allocate a second buffer for the
decoded strings. We use it for the struct mces right now.

And 1-2 pages should be fine:

8192 / 128 = 64 decoded strings in flight.

I guess that should cover most situations. Famous last words.

In any case, thanks for pointing this out.

--
Regards/Gruss,
Boris.

ECO tip #101: Trim your mails when you reply.
--