Re: [PATCH v8 01/13] iommu/amd: Detect pre enabled translation

From: Baoquan He
Date: Thu Jul 27 2017 - 22:31:13 EST


On 07/27/17 at 05:04pm, Joerg Roedel wrote:
> On Fri, Jul 21, 2017 at 04:58:59PM +0800, Baoquan He wrote:
> > diff --git a/drivers/iommu/amd_iommu_types.h b/drivers/iommu/amd_iommu_types.h
> > index 294a409e283b..d15966b62b33 100644
> > --- a/drivers/iommu/amd_iommu_types.h
> > +++ b/drivers/iommu/amd_iommu_types.h
> > @@ -417,6 +417,7 @@ extern struct kmem_cache *amd_iommu_irq_cache;
> > #define APERTURE_PAGE_INDEX(a) (((a) >> 21) & 0x3fULL)
> >
> >
> > +
>
> Forgot to remove that from the diff?

Many thanks for your reviewing and great suggestions, Joerg!

Will withdraw this change in this patch.

>
> > /*
> > * This struct is used to pass information about
> > * incoming PPR faults around.
> > @@ -435,6 +436,8 @@ struct iommu_domain;
> > struct irq_domain;
> > struct amd_irte_ops;
> >
> > +#define AMD_IOMMU_FLAG_TRANS_PRE_ENABLED (1 << 0)
> > +
> > /*
> > * This structure contains generic data for IOMMU protection domains
> > * independent of their use.