Re: [PATCH v3 1/3] ptp: introduce ptp auxiliary worker

[Grygorii Strashko]

On 07/27/2017 03:08 PM, Richard Cochran wrote:
> On Wed, Jul 26, 2017 at 05:11:36PM -0500, Grygorii Strashko wrote:
> > @@ -217,6 +231,19 @@ struct ptp_clock *ptp_clock_register(struct ptp_clock_info *info,
> >   	mutex_init(&ptp->pincfg_mux);
> >   	init_waitqueue_head(&ptp->tsev_wq);
> >   
> > +	if (ptp->info->do_aux_work) {
> > +		char *worker_name = kasprintf(GFP_KERNEL, "ptp%d", ptp->index);
>
> This string is allocated but never freed.
>
> > +		kthread_init_delayed_work(&ptp->aux_work, ptp_aux_kworker);
> > +		ptp->kworker = kthread_create_worker(0, worker_name ?
> > +						     worker_name : info->name);

Ops. Right need to add kfree(worker_name) here.


> > +		if (IS_ERR(ptp->kworker)) {
> > +			err = PTR_ERR(ptp->kworker);
> > +			pr_err("failed to create ptp aux_worker %d\n", err);
> > +			goto kworker_err;
> > +		}
> > +	}
> > +
>
> Thanks,
> Richard

--
regards,
-grygorii