Re: [PATCH v6] workqueue: Fix edge cases for calc of pool's cpumask

From: Michael Bringmann
Date: Thu Jul 27 2017 - 15:13:01 EST



>>
>> /* yeap, return possible CPUs in @node that @attrs wants */
>> cpumask_and(cpumask, attrs->cpumask, wq_numa_possible_cpumask[node]);
>> +
>> + if (cpumask_empty(cpumask)) {
>> + pr_warn_once("WARNING: workqueue cpumask: onl intersect > "
> ^^^
> This message doesn't seem right, or I am missing something, "onl"?

Shorthand for 'online' in long message.

>
> -Nathan
>
>> + "possible intersect\n");
>> + return false;
>> + }
>> +
>> return !cpumask_equal(cpumask, attrs->cpumask);
>>
>> use_dfl:
>>
>

--
Michael W. Bringmann
Linux Technology Center
IBM Corporation
Tie-Line 363-5196
External: (512) 286-5196
Cell: (512) 466-0650
mwb@xxxxxxxxxxxxxxxxxx