Re: [Intel-gfx] [PATCH 0/3] Kconfig dependencies: acpi-video, backlight and thermal

From: Daniel Vetter
Date: Wed Jul 26 2017 - 10:40:51 EST


On Wed, Jul 26, 2017 at 03:53:09PM +0200, Arnd Bergmann wrote:
> Hi everyone,
>
> It took me a while to figure this out properly, as I kept getting
> circular or missing dependencies with video drivers.
>
> This set of three patches should simplify the situation a bit,
> mostly by cleaning up the dependencies around CONFIG_ACPI_VIDEO.
> With all three patches applied, I no longer run into those related
> warnings. If everyone agrees on the general direction, I hope
> we can merge all three through the DRM tree.
>
> I originally had another larger patch in the series to replace all
> of the 'select BACKLIGHT_LCD_SUPPORT; select BACKLIGHT_CLASS_DEVICE'
> statements with 'depends on LCD_CLASS_DEVICE', that would clean
> it up some more, but it is also a more invasive change that we
> can do separately at some point.

Looks reasonable, but I think it'd be good to get Jani Nikula's explicit
ack on this, since he dugg around a lot in this area. And he's on vacation
this week.
-Daniel

>
> Arnd
>
> Arnd Bergmann (3):
> backlight: always select BACKLIGHT_LCD_SUPPORT for
> BACKLIGHT_CLASS_DEVICE
> ACPI/DRM: rework ACPI_VIDEO Kconfig dependencies
> drm/etnaviv: add thermal dependency
>
> drivers/acpi/Kconfig | 7 +++++--
> drivers/gpu/drm/etnaviv/Kconfig | 1 +
> drivers/gpu/drm/gma500/Kconfig | 5 +----
> drivers/gpu/drm/i915/Kconfig | 7 +------
> drivers/gpu/drm/nouveau/Kconfig | 10 ++--------
> drivers/platform/x86/Kconfig | 9 ++++-----
> drivers/staging/olpc_dcon/Kconfig | 1 +
> 7 files changed, 15 insertions(+), 25 deletions(-)
>
> To: dri-devel@xxxxxxxxxxxxxxxxxxxxx
> Cc: "Rafael J. Wysocki" <rjw@xxxxxxxxxxxxx>
> Cc: Len Brown <lenb@xxxxxxxxxx>
> Cc: Lucas Stach <l.stach@xxxxxxxxxxxxxx>
> Cc: Russell King <linux+etnaviv@xxxxxxxxxxxxxxx>
> Cc: Christian Gmeiner <christian.gmeiner@xxxxxxxxx>
> Cc: David Airlie <airlied@xxxxxxxx>
> Cc: Patrik Jakobsson <patrik.r.jakobsson@xxxxxxxxx>
> Cc: Daniel Vetter <daniel.vetter@xxxxxxxxx>
> Cc: Jani Nikula <jani.nikula@xxxxxxxxxxxxxxx>
> Cc: Ben Skeggs <bskeggs@xxxxxxxxxx>
> Cc: Darren Hart <dvhart@xxxxxxxxxxxxx>
> Cc: Andy Shevchenko <andy@xxxxxxxxxxxxx>
> Cc: Jens Frederich <jfrederich@xxxxxxxxx>
> Cc: Daniel Drake <dsd@xxxxxxxxxx>
> Cc: Jon Nettleton <jon.nettleton@xxxxxxxxx>
> Cc: Greg Kroah-Hartman <gregkh@xxxxxxxxxxxxxxxxxxx>
> Cc: linux-acpi@xxxxxxxxxxxxxxx
> Cc: linux-kernel@xxxxxxxxxxxxxxx
> Cc: etnaviv@xxxxxxxxxxxxxxxxxxxxx
> Cc: intel-gfx@xxxxxxxxxxxxxxxxxxxxx
> Cc: nouveau@xxxxxxxxxxxxxxxxxxxxx
> Cc: platform-driver-x86@xxxxxxxxxxxxxxx
> Cc: devel@xxxxxxxxxxxxxxxxxxxx
>
> --
> 2.9.0
>
> _______________________________________________
> Intel-gfx mailing list
> Intel-gfx@xxxxxxxxxxxxxxxxxxxxx
> https://lists.freedesktop.org/mailman/listinfo/intel-gfx

--
Daniel Vetter
Software Engineer, Intel Corporation
http://blog.ffwll.ch