Re: [PATCH] irqchip: create a Kconfig menu for irqchip drivers

From: Thomas Gleixner
Date: Wed Jul 26 2017 - 10:24:38 EST


On Wed, 26 Jul 2017, Marc Zyngier wrote:
> On 26/07/17 14:14, Masahiro Yamada wrote:
> > The irqchip maintainers applied drivers
> > with user-configurable Kconfig entries.
>
> They are *not* user-selectable, since there is *NO* menu entry. *You*
> are making them user-selectable, and I'm objecting to that.

Masahiro is right. They are user selectable.

Enable CONFIG_SOC_IMX51 and you'll get a prompt for

TS-4800 IRQ controller

in the middle of the 'Device Drivers' menu. Same for the other options,
which have prompts. The irqchip Kconfig is included from drivers/Kconfig so
there is menu context, just not a proper one.

I agree that this is crap and these prompts should be removed and the irq
thingy selected by the stuff which needs it.

Thanks,

tglx