Re: [PATCH v1] pwm: pca9685: clarify pca9685_set_sleep_mode() interface.

From: Thierry Reding
Date: Tue Jul 25 2017 - 07:42:26 EST


On Fri, Apr 21, 2017 at 09:19:02AM -0400, Sven Van Asbroeck wrote:
> The function
> static void pca9685_set_sleep_mode(struct pca9685 *pca, int sleep)
> takes the chip in and out of sleep mode, depending on the value of
> sleep, which is interpreted as a boolean.
>
> To clarify that 'int sleep' is a boolean and not a sleep delay,
> change the function interface to:
> static void pca9685_set_sleep_mode(struct pca9685 *pca, bool enable)
>
> Suggested-by: Andy Shevchenko <andriy.shevchenko@xxxxxxxxxxxxxxx>
> Signed-off-by: Sven Van Asbroeck <thesven73@xxxxxxxxx>
> ---
> drivers/pwm/pwm-pca9685.c | 14 +++++++-------
> 1 file changed, 7 insertions(+), 7 deletions(-)

Applied, thanks.

Thierry

Attachment: signature.asc
Description: PGP signature