Re: [PATCH 2/4] gpio: tegra: Prefer kcalloc() over kzalloc() with multiplies

From: Jon Hunter
Date: Tue Jul 25 2017 - 04:27:29 EST




On 24/07/17 15:55, Thierry Reding wrote:
> From: Thierry Reding <treding@xxxxxxxxxx>
>
> Rather than manually compute the size of an array, pass the number and
> element size to kcalloc().
>
> Signed-off-by: Thierry Reding <treding@xxxxxxxxxx>
> ---
> drivers/gpio/gpio-tegra.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/gpio/gpio-tegra.c b/drivers/gpio/gpio-tegra.c
> index 63ee221f9be9..1d4df290d7ab 100644
> --- a/drivers/gpio/gpio-tegra.c
> +++ b/drivers/gpio/gpio-tegra.c
> @@ -621,10 +621,10 @@ static int tegra_gpio_probe(struct platform_device *pdev)
> if (tgi->soc->debounce_supported)
> tgi->gc.set_config = tegra_gpio_set_config;
>
> - tgi->bank_info = devm_kzalloc(&pdev->dev, tgi->bank_count *
> + tgi->bank_info = devm_kcalloc(&pdev->dev, tgi->bank_count,
> sizeof(*tgi->bank_info), GFP_KERNEL);
> if (!tgi->bank_info)
> - return -ENODEV;
> + return -ENOMEM;
>
> tgi->irq_domain = irq_domain_add_linear(pdev->dev.of_node,
> tgi->gc.ngpio,
>

Acked-by: Jon Hunter <jonathanh@xxxxxxxxxx>

Cheers
Jon

--
nvpublic