Re: [PATCH 07/11] mfd: Drop unnecessary static

From: Kees Cook
Date: Mon Jul 24 2017 - 18:27:24 EST


On Mon, Jul 24, 2017 at 12:20 PM, Pavel Machek <pavel@xxxxxx> wrote:
> Hi!
>
>> > > Drop static on a local variable, when the variable is initialized before
>> > > any possible use. Thus, the static has no benefit.
>
> Actually... it has possible other benefit -- saving stack space. I've
> used static for that purpose before. So ... careful with the
> automation.

This means any functions like this must not be thread safe, though...

-Kees

--
Kees Cook
Pixel Security