Re: [PATCH v5] printk: Add pr_info_show_time

From: Mark Salyzyn
Date: Mon Jul 24 2017 - 11:47:50 EST


On 07/22/2017 02:40 AM, Pavel Machek wrote:
For example, the persistent clock that is used to report
"Suspended for" message, although very useful, is not present on all
platforms. It is currently standardized for millisecond precision.
Fix that on your platforms, instead?

Pavel

lol :-)

That is a _hardware_ issue. For a vast majority of them, the persistent read-only clock requires a LTE, always-on ready to wakeup device for a phone call, correction factor from a separate driver. In some cases the persistent clock requires a hardware re-init sequence to a pmic controller that occurs higher up in the resume chain. For those where it is possible, please remember there are 25K different Android devices, represented in nearly 2B hands. Feel free to tell all the implementors just how important a continuously accessible working 100% tuned accurate persistent clock is when _this_ _one_ flawed (ms accuracy, no lte correction while asleep) print is the only place which gains from said access ;-). I am blue in the face just working with the limited set I have influence on.

And yet, add a simple print of realtime clock at suspend and resume points higher up in the chain always works regardless of the hardware or the driver skills of the vendor building the devices.


-- Mark