Re: [PATCH] dmaengine: ioatdma: Fix error handling path in 'ioat_dma_self_test()'

[Jiang, Dave]

> On Jul 20, 2017, at 11:28 PM, Koul, Vinod <vinod.koul@xxxxxxxxx> wrote:
> 
>> On Wed, Jul 19, 2017 at 03:21:23PM -0700, Dave Jiang wrote:
>> 
>> 
>>> On 07/19/2017 03:16 PM, Christophe JAILLET wrote:
>>> If the 'memcmp' fails, free allocated resources as done in all other
>>> error handling paths.
>>> 
>>> Signed-off-by: Christophe JAILLET <christophe.jaillet@xxxxxxxxxx>
> 
> You meant acked right..?

Yes. Typo :)

> 
>> 
>> Good catch! Thanks.
>> 
>> Signed-off-by: Dave Jiang <dave.jiang@xxxxxxxxx>
>> 
>>> ---
>>> Please review carefully, this patch looks "too obvious" to me!
>>> ---
>>> drivers/dma/ioat/init.c | 2 +-
>>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>> 
>>> diff --git a/drivers/dma/ioat/init.c b/drivers/dma/ioat/init.c
>>> index ed8ed1192775..948fc1f8fb5c 100644
>>> --- a/drivers/dma/ioat/init.c
>>> +++ b/drivers/dma/ioat/init.c
>>> @@ -390,7 +390,7 @@ static int ioat_dma_self_test(struct ioatdma_device *ioat_dma)
>>>    if (memcmp(src, dest, IOAT_TEST_SIZE)) {
>>>        dev_err(dev, "Self-test copy failed compare, disabling\n");
>>>        err = -ENODEV;
>>> -        goto free_resources;
>>> +        goto unmap_dma;
>>>    }
>>> 
>>> unmap_dma:
>>> 
> 
> -- 
> ~Vinod