Re: [PATCH] fpga: Convert to using %pOF instead of full_name

From: Alan Tull
Date: Wed Jul 19 2017 - 10:33:10 EST


On Tue, Jul 18, 2017 at 11:42 PM, Moritz Fischer <mdf@xxxxxxxxxx> wrote:
> On Tue, Jul 18, 2017 at 04:43:02PM -0500, Rob Herring wrote:
>> Now that we have a custom printf format specifier, convert users of
>> full_name to use %pOF instead. This is preparation to remove storing
>> of the full path string for each node.
>>
>> Signed-off-by: Rob Herring <robh@xxxxxxxxxx>
>> Cc: Alan Tull <atull@xxxxxxxxxx>
>> Cc: Moritz Fischer <moritz.fischer@xxxxxxxxx>
>> Cc: linux-fpga@xxxxxxxxxxxxxxx
> Acked-by: Moritz Fischer <mdf@xxxxxxxxxx>

Acked-by: Alan Tull <atull@xxxxxxxxxx>

>> ---
>> drivers/fpga/fpga-region.c | 4 ++--
>> 1 file changed, 2 insertions(+), 2 deletions(-)
>>
>> diff --git a/drivers/fpga/fpga-region.c b/drivers/fpga/fpga-region.c
>> index 3b6b2f4182a1..d9ab7c75b14f 100644
>> --- a/drivers/fpga/fpga-region.c
>> +++ b/drivers/fpga/fpga-region.c
>> @@ -319,8 +319,8 @@ static int child_regions_with_firmware(struct device_node *overlay)
>> of_node_put(child_region);
>>
>> if (ret)
>> - pr_err("firmware-name not allowed in child FPGA region: %s",
>> - child_region->full_name);
>> + pr_err("firmware-name not allowed in child FPGA region: %pOF",
>> + child_region);
>>
>> return ret;
>> }
>> --
>> 2.11.0
>>