Re: [PATCH 2/3] mfd: syscon: atmel-smc: add helper to retrieve register layout

From: Lee Jones
Date: Tue Jul 18 2017 - 05:12:48 EST


On Tue, 18 Jul 2017, Lee Jones wrote:

> On Tue, 11 Jul 2017, Ludovic Desroches wrote:
>
> > For HSMC controller, the register layout depends on the device i.e. the
> > offset of setup, pulse, cycle, mode and timings registers is not the
> > same. An helper is added to provide the correct register layout.
> >
> > Fixes: fe9d7cb22ef3 ("mfd: syscon: atmel-smc: Add new helpers to ease
> > SMC regs manipulation")
> > Suggested-by: Boris Brezillon <boris.brezillon@xxxxxxxxxxxxxxxxxx>
> > Signed-off-by: Ludovic Desroches <ludovic.desroches@xxxxxxxxxxxxx>
> > ---
> > drivers/memory/atmel-ebi.c | 13 +++++--
> > drivers/mfd/atmel-smc.c | 67 +++++++++++++++++++++++++-------
> > drivers/mtd/nand/atmel/nand-controller.c | 10 +++--
> > include/linux/mfd/syscon/atmel-smc.h | 32 ++++++++++-----
> > 4 files changed, 92 insertions(+), 30 deletions(-)
>
> Applied, thanks.

Apologies, it looks like this needs 2 more Acks before I can even
consider taking it.

Unapplied.

--
Lee Jones
Linaro STMicroelectronics Landing Team Lead
Linaro.org â Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog