Re: [PATCH] dt-bindings: display: sunxi: Improve endpoint ID scheme readability

From: Chen-Yu Tsai
Date: Tue Jul 11 2017 - 22:39:10 EST


On Wed, Jul 12, 2017 at 3:31 AM, Maxime Ripard
<maxime.ripard@xxxxxxxxxxxxxxxxxx> wrote:
> On Mon, Jul 10, 2017 at 11:48:00PM +0800, Chen-Yu Tsai wrote:
>> On Sun, Jun 18, 2017 at 10:05 PM, Rob Herring <robh@xxxxxxxxxx> wrote:
>> > On Wed, Jun 14, 2017 at 02:30:16PM +0800, Chen-Yu Tsai wrote:
>> >> The explanation for the endpoint ID numbering scheme is convoluted
>> >> and hard to understand.
>> >>
>> >> This patch aims to improve the readability of it by combining the
>> >> existing two paragraphs, while also providing a diagram example,
>> >> and how endpoints should be numbered based on that example.
>> >>
>> >> Signed-off-by: Chen-Yu Tsai <wens@xxxxxxxx>
>> >> ---
>> >>
>> >> Hope this helps. I'm not sure I can improve this even more without
>> >> spelling out all cases.
>> >>
>> >> ---
>> >> .../bindings/display/sunxi/sun4i-drm.txt | 36 ++++++++++++++++------
>> >> 1 file changed, 27 insertions(+), 9 deletions(-)
>> >
>> > Acked-by: Rob Herring <robh@xxxxxxxxxx>
>>
>> Maxime, this patch seems to have fallen through the cracks.
>>
>> Could you queue it as a fix for 4.13?
>
> Sorry, I don't know why I overlooked it.
>
> Is it really 4.13 material though? It doesn't look that urgent.

Unless I'm mistaken, this clarifies the numbering scheme introduced
in 4.13. I'd say that's enough reason to have it in the same release.

But I should update the diagram first. The backend <-> TCON mux is
missing. And maybe a Fixes tag.

ChenYu