Re: [PATCH] usb: isp1760: compress return logic into one line

From: Oliver Neukum
Date: Mon Jul 10 2017 - 03:39:28 EST


Am Sonntag, den 09.07.2017, 21:00 -0500 schrieb Gustavo A. R. Silva :
> Simplify return logic to avoid unnecessary variable assignment.
>
> This issue was detected using Coccinelle and the following
> semantic patch:
>

Hi,

I need to ask: Where is the improvement? The compiler does not bother
and for the human reader you do not do anything obvious and you
decreased grepability.

Regards
Oliver