Re: [PATCH v2 3/4] btrfs: Add zstd support

From: Adam Borowski
Date: Fri Jul 07 2017 - 19:41:09 EST


On Fri, Jul 07, 2017 at 11:17:49PM +0000, Nick Terrell wrote:
> On 7/6/17, 9:32 AM, "Adam Borowski" <kilobyte@xxxxxxxxxx> wrote:
> > Got a reproducible crash on amd64:
> >
> > [98235.266511] BUG: unable to handle kernel paging request at ffffc90001251000

> > [98235.314008] ? ZSTD_compressBlock_fast+0x94b/0xb30
> > [98235.315975] ? ZSTD_compressContinue_internal+0x1a0/0x580
> > [98235.317938] ? ZSTD_compressStream_generic+0x248/0x2f0
> > [98235.319877] ? ZSTD_compressStream+0x41/0x60
> > [98235.321821] ? zstd_compress_pages+0x236/0x5d0
> > [98235.323724] ? btrfs_compress_pages+0x5e/0x80
> > [98235.325684] ? compress_file_range.constprop.79+0x1eb/0x750
>
> Thanks for the bug report Adam! I'm looking into the failure, and haven't
> been able to reproduce it yet. I've built my kernel from your tree, and
> I ran your script with the kernel.tar tarball 100 times, but haven't gotten
> a failure yet.

Crashed the same way 4 out of 4 tries for me.

> I have a few questions to guide my debugging.
>
> - How many cores are you running with? Iâve run the script with 1, 2, and 4 cores.
> - Which version of gcc are you using to compile the kernel? Iâm using gcc-6.2.0-5ubuntu12.
> - Are the failures always in exactly the same place, and does it fail 100%
> of the time or just regularly?

6 cores -- all on bare metal. gcc-7.1.0-9.

Lemme try with gcc-6, a different config or in a VM.

--
âââââââ
âââââââ A dumb species has no way to open a tuna can.
âââââââ A smart species invents a can opener.
âââââââ A master species delegates.