Re: [RFC PATCH linus] tcp: md5: tcp_md5_do_lookup_exact() can be static

From: Stephen Rothwell
Date: Wed Jul 05 2017 - 20:27:25 EST


Hi,

Not sure why you sent this to me ... it fixes a commit in the net-next
tree (now in Linus' tree) ...

On Thu, 6 Jul 2017 07:58:53 +0800 kbuild test robot <fengguang.wu@xxxxxxxxx> wrote:
>
> Fixes: 0c5f0311f690 ("Add linux-next specific files for 20170705")

Actually: Fixes: 6797318e623d ("tcp: md5: add an address prefix for key lookup")

> Signed-off-by: Fengguang Wu <fengguang.wu@xxxxxxxxx>
> ---
> tcp_ipv4.c | 6 +++---
> 1 file changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/net/ipv4/tcp_ipv4.c b/net/ipv4/tcp_ipv4.c
> index 6ec6900..a20e7f0 100644
> --- a/net/ipv4/tcp_ipv4.c
> +++ b/net/ipv4/tcp_ipv4.c
> @@ -943,9 +943,9 @@ struct tcp_md5sig_key *tcp_md5_do_lookup(const struct sock *sk,
> }
> EXPORT_SYMBOL(tcp_md5_do_lookup);
>
> -struct tcp_md5sig_key *tcp_md5_do_lookup_exact(const struct sock *sk,
> - const union tcp_md5_addr *addr,
> - int family, u8 prefixlen)
> +static struct tcp_md5sig_key *tcp_md5_do_lookup_exact(const struct sock *sk,
> + const union tcp_md5_addr *addr,
> + int family, u8 prefixlen)
> {
> const struct tcp_sock *tp = tcp_sk(sk);
> struct tcp_md5sig_key *key;

--
Cheers,
Stephen Rothwell