Re: [PATCH] RFC: platform/x86: wmi: Fix check for method instance number

From: David Airlie
Date: Wed Jul 05 2017 - 15:30:42 EST




----- Original Message -----
> From: "Pali RohÃr" <pali.rohar@xxxxxxxxx>
> To: "Chun-Yi Lee" <jlee@xxxxxxxx>, "Corentin Chary" <corentin.chary@xxxxxxxxx>, acpi4asus-user@xxxxxxxxxxxxxxxxxxxxx,
> "Dave Airlie" <airlied@xxxxxxxxxx>, "Oleksij Rempel" <linux@xxxxxxxxxxxxxxxx>, "JoÃo Paulo Rechi Vita"
> <jprvita@xxxxxxxxx>
> Cc: "Darren Hart" <dvhart@xxxxxxxxxxxxx>, "Andy Shevchenko" <andy@xxxxxxxxxxxxx>, "Andy Lutomirski"
> <luto@xxxxxxxxxx>, platform-driver-x86@xxxxxxxxxxxxxxx, linux-kernel@xxxxxxxxxxxxxxx
> Sent: Wednesday, 5 July, 2017 7:51:13 PM
> Subject: Re: [PATCH] RFC: platform/x86: wmi: Fix check for method instance number
>
> On Saturday 17 June 2017 18:47:54 Pali RohÃr wrote:
> > > So problematic drivers which use instance=1 without any comments are:
> > >
> > > acer-wmi
> > > asus-wmi
> > > mxm-wmi
> >
> > Adding authors & maintainers of those drivers in loop.
>
> Hi!
>
> Dell drivers and acer-wmi are fixed now. So only asus-wmi and mxm-wmi
> needs to be investigated.
>
> Adding more people who developed those drivers recently in loop. Can you
> check if instance number is used correctly or not?
>

I've no memory of why I picked 1 or 0, I probably cut-n-paste it from
somewhere else.

Dave.