Re: [PATCH][bpf-next] bpf: add missing break in for the TCP_BPF_SNDCWND_CLAMP case

From: David Miller
Date: Wed Jul 05 2017 - 04:09:34 EST


From: Colin King <colin.king@xxxxxxxxxxxxx>
Date: Tue, 4 Jul 2017 16:21:12 +0100

> From: Colin Ian King <colin.king@xxxxxxxxxxxxx>
>
> There appears to be a missing break in the TCP_BPF_SNDCWND_CLAMP case.
> Currently the non-error path where val is greater than zero falls through
> to the default case that sets the error return to -EINVAL. Add in
> the missing break.
>
> Detected by CoverityScan, CID#1449376 ("Missing break in switch")
>
> Fixes: 13bf96411ad2 ("bpf: Adds support for setting sndcwnd clamp")
> Signed-off-by: Colin Ian King <colin.king@xxxxxxxxxxxxx>

Applied.