Re: [PATCH 2/2] f2fs: reuse original mount option in ->remount_fs

From: Jaegeuk Kim
Date: Sat Jul 01 2017 - 03:51:29 EST


On 06/29, Chao Yu wrote:
> From: Chao Yu <yuchao0@xxxxxxxxxx>
>
> Don't clear old mount option before parse new option during ->remount_fs
> like other generic filesystems.

So, what happened on your original patch?

commit 26666c8a4366debae30ae37d0688b2bec92d196a
f2fs: fix to clean previous mount option when remount_fs

I think we need to rever the original patch tho.

Thanks,

>
> Signed-off-by: Chao Yu <yuchao0@xxxxxxxxxx>
> ---
> fs/f2fs/super.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/fs/f2fs/super.c b/fs/f2fs/super.c
> index f27c141cd8aa..af472f7968d0 100644
> --- a/fs/f2fs/super.c
> +++ b/fs/f2fs/super.c
> @@ -846,7 +846,6 @@ static int f2fs_remount(struct super_block *sb, int *flags, char *data)
> clear_sbi_flag(sbi, SBI_NEED_SB_WRITE);
> }
>
> - sbi->mount_opt.opt = 0;
> default_options(sbi);
>
> /* parse mount options */
> --
> 2.13.0.90.g1eb437020